Skip to content

Fix typo and numbered list in variational algo doc #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

Fix typo and numbered list in variational algo doc #7647

merged 1 commit into from
Sep 11, 2025
+5 −5

Conversation

ToastCheng
Copy link
Contributor

  1. The numbered list in official doc isn't displaying as expected
  2. Typo in sympy.Symbol

@ToastCheng
Fix typo and number list in variational algo doc
c2a6c57 
1. The numbered list in official doc isn't displaying as expected
2. Typo in sympy.Symbol
@ToastCheng ToastCheng requested review from a team and vtomole as code owners September 11, 2025 09:39
@ToastCheng ToastCheng requested a review from viathor September 11, 2025 09:39
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the size: S 10< lines changed <50 label Sep 11, 2025
@ToastCheng
Copy link
Contributor Author

ToastCheng commented Sep 11, 2025 •
edited
Loading

Hi!

When I was reading https://quantumai.google/cirq/experiments/variational_algorithm, I found a typo and the numbered list showing "1." for all the items. Just made this simple PR to fix this.

Verified this change from my local jupyter notebook, it shows as below:
image

Let me know if I need to create an issue for this. Thanks!

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.36%. Comparing base (25d727f) to head (c2a6c57).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7647      +/-   ##
==========================================
- Coverage   99.37%   99.36%   -0.01%     
==========================================
  Files        1078     1078              
  Lines       96166    96166              
==========================================
- Hits        95563    95558       -5     
- Misses        603      608       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pavoljuhas
pavoljuhas approved these changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavoljuhas pavoljuhas added this pull request to the merge queue Sep 11, 2025
Merged via the queue into quantumlib:main with commit 97781c7 Sep 11, 2025
35 checks passed
@NoureldinYosri NoureldinYosri mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@vtomole vtomole Awaiting requested review from vtomole vtomole is a code owner

@viathor viathor Awaiting requested review from viathor viathor is a code owner automatically assigned from quantumlib/cirq-maintainers

Assignees

No one assigned

Labels

size: S 10< lines changed <50

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ToastCheng @pavoljuhas